search

mozilla / spidernode

Node.js on top of SpiderMonkey
https://ehsanakhgari.org/blog/2016-04-20/project-spidernode
Other
559 stars 43 forks source link

Merge node #372

Closed mykmelez closed 6 years ago

mykmelez commented 7 years ago

The bustage here comes from the landing of the ABI-stable Node API (https://github.com/nodejs/node/pull/11975), which adds a napi_create_symbol function to node_api.cc that references v8::Symbol, which we haven't yet shimmed.

tbsaunde commented 7 years ago

On Tue, Apr 04, 2017 at 10:17:53AM -0700, Myk Melez wrote:

The bustage here comes from the landing of the ABI-stable Node API (nodejs/node

11975), which adds a napi_create_symbol function to node_api.cc that

references v8::Symbol, which we haven't yet shimmed.

I bet that's not too hard to implement, I'll take a look tomorrow.

Trev

mykmelez commented 7 years ago

I bet that's not too hard to implement, I'll take a look tomorrow.

@tbsaunde Note this comment on line 890 of deps/spidershim/src/v8objecttemplate.cc:

// TODO: Handle symbols here when we implement v8::Symbol
mykmelez commented 6 years ago

I've been maintaining this PR but haven't had time to actually fix the issues, which seems unuseful, so I'm going to close this PR while keeping the branch around in case I or someone else wants to pick up this work again.