Closed claudijd closed 2 years ago
@tsellers-r7, would you mind sharing any open-source bits on how you think would be the best way to shim this in? I will find the bits in ssh_scan where this is implemented and share links in further comments.
This is where some of the magic happens, I suspect we can probably just expose an alternative method to start with that just makes a call to recog and retrieves whatever we know and then we can compare the two against a series of example cases and see if there's a significant value add. Happy to write most of the code, but having a "this is the best way to call recog" info would speed it up.
https://github.com/mozilla/ssh_scan/blob/master/lib/ssh_scan/banner.rb#L35-L101
@claudijd Sorry, I've been a bit tied up. I'll try to provide something useful in the next couple of days.
Bailing on this.
@claudijd - I'm seriously sorry that I never got around to this. Oddly enough, I literally had a discussion with Tod yesterday in which I brought it up.
If you would like it reopened, we can totally do that.
Thanks. I'll see what I can do to either set aside time for this or let you know that I can't.
@tsellers-r7 all good. Good to hear from you!
Just so this is not lost into the ether...
https://github.com/rapid7/recog
/cc @tsellers-r7