search

mozilla / ssh_scan_api

An API for ssh_scan (https://github.com/mozilla/ssh_scan) and the backend API service for the Mozilla SSH Observatory (https://observatory.mozilla.org/)
31 stars 8 forks source link

Caching does not appear to be working #27

Closed claudijd closed 7 years ago

claudijd commented 7 years ago

We implemented caching at one point, but I've received reports from people stating that they are getting unique UUIDs for repeated scans of the same property.

It's possible we're doing wrong, or the config it's set properly, but creating this bug to verify so it's not forgotten.

claudijd commented 7 years ago

/cc @royalharsh @rishabhs95 FYI

claudijd commented 7 years ago

I see some refs to this here, but doesn't look fully implemented...

https://github.com/mozilla/ssh_scan_api/blob/master/lib/ssh_scan_api/api.rb#L58-L60

I do recall reviewing a PR for this.

claudijd commented 7 years ago

Prior PR => https://github.com/mozilla/ssh_scan/pull/305

claudijd commented 7 years ago

related to #40