search

mozilla / ssl-config-generator

Mozilla SSL Configuration Generator
https://ssl-config.mozilla.org/
Mozilla Public License 2.0
358 stars 59 forks source link

chore: Remove obsolete postfix parameter `smtpd_use_tls` #94

Closed polarathene closed 4 years ago

polarathene commented 4 years ago

smtpd_tls_security_level has replaced this config parameter. smtpd_use_tls has no relevance in the config anymore.

See: http://www.postfix.org/postconf.5.html#smtpd_tls_security_level

this overrides the obsolete parameters smtpd_use_tls and smtpd_enforce_tls.

april commented 4 years ago

Could you fix up the newline change at the end of the file please?

april commented 4 years ago

I don't think your commit made any changes? 😅

polarathene commented 4 years ago

Github doesn't seem to support doing so and is enforcing it :disappointed: I'll need to edit it locally I guess.

Any reason for this requirement btw? It's not mentioned on the README and I think I recall you asking someone else before to do the same?

Reasons for keeping it:

A text file, under unix, consists of a series of lines, each of which ends with a newline character (\n). A file that is not empty and does not end with a newline is therefore not a text file.

POSIX, this is a set of standards specified by IEEE to maintain compatibility between operating systems. One of which is the definition of a "line" being a sequence of zero or more non- characters plus a terminating newline character. So for that last line to be recognised as an actual "line" it should have a terminating new line character.

april commented 4 years ago

The templates render that extra line if they're there, so it needs to not be inside any of them. :)

polarathene commented 4 years ago

Resolved.