search

mozilla / standup

web app that logs daily standup updates
https://www.standu.ps
BSD 3-Clause "New" or "Revised" License
64 stars 32 forks source link

prettify github urls #367

Open nox opened 7 years ago

nox commented 7 years ago

Most of the links I write on standups get truncated, is it really useful for the maximum displayed length to be that short?

pmac commented 7 years ago

It's useful to have some truncation due to really long words breaking the CSS width constraints, but we could increase the max for that. Do you have a suggestion?

nox commented 7 years ago

@pmac Given what you just said, what about trying to make it as long as possible while still fitting the box it's in?

nox commented 7 years ago

Actually, what about just prettifying GitHub links to user/repos#number?

pmac commented 7 years ago

we do already link to a PR if you're posting in a project with a github repo configured and you say pr #1234 in your status. e.g.

pmac commented 7 years ago

not saying I wouldn't be happy with a more general github URL pretifier, and probably one for bugzilla links. Not sure I have time to put together a PR for it, but would happily review one.

willkg commented 7 years ago

I'm going to change this to "prettify github urls" since that's the underlying issue and not truncation.

willkg commented 7 years ago

I think this is something that we want. Further, I think this (supporting prettifying specified urls (github, bugzilla, etc)) is something we could easily do in a Filter once I get Bleach 2.0 out the door. I'll keep this in mind while I'm working on Bleach.

willkg commented 7 years ago

Bugzilla added this: https://bugzilla.mozilla.org/show_bug.cgi?id=1309112

I'd be up for ditching our existing "pull #xyz" handling in favor of more general github "user/repo#num" support. Maybe we could go through and migrate all the existing statuses, too.