search

mozilla / sugardough

A web application template based on Django.
Apache License 2.0
164 stars 31 forks source link

Upgrade to Django 1.10.1 #129

Closed glogiotatidis closed 8 years ago

glogiotatidis commented 8 years ago

This is currently blocked by django-session-csrf being incompatible with Django 1.10. There's an open pull request to fix that: https://github.com/mozilla/django-session-csrf/pull/30

@peterbe maybe you can push things forward?

peterbe commented 8 years ago

I left some comments https://github.com/mozilla/django-session-csrf/pull/30 but once that lands I can take care up updating pypi. Then we can proceed on this PR.

glogiotatidis commented 8 years ago

@peterbe updated!

peterbe commented 8 years ago

We might need to go back to django-session-csrf and work on this. But I just created a fresh new install based on this branch and it won't even start.

screen shot 2016-10-03 at 8 49 47 am

The fault lies with django-session-csrf but we have to take responsibility of that.

peterbe commented 8 years ago

Let's hope @moggers87 finds the time to complete the python 3 support. https://github.com/mozilla/django-session-csrf/issues/20#issuecomment-162044638

I just can't accept that we say that sugardough is compatible with django 1.10 but doesn't work in Python 3.

glogiotatidis commented 8 years ago

Fair enough, let's wait that for a week. @moggers87 is already working on py3

peterbe commented 8 years ago

I tested your PR together with the python3 branch that @moggers87 is working on and now my recently created sugardough python 3.5 project worked. See https://github.com/mozilla/django-session-csrf/pull/36#pullrequestreview-2727721

The only testing I did was to load the home page. But that didn't work before.

So let's pause on this PR until we can also include a new django-session-csrf version hashed in.

glogiotatidis commented 8 years ago

woohoo! @peterbe updated, feel free to squash merge