search

mozilla / sugardough

A web application template based on Django.
Apache License 2.0
164 stars 31 forks source link

Add fe filter for jinja2 templates #98

Closed bobsilverberg closed 8 years ago

bobsilverberg commented 9 years ago

As per @glogiotatidis's suggestion at https://github.com/mozilla/oneanddone/pull/301#discussion_r43484696

r?

ghost commented 9 years ago

Can one of the admins verify this patch?

glogiotatidis commented 9 years ago

ok to test

glogiotatidis commented 9 years ago

@bobsilverberg thanks for the pull request! Can you please make use of the filter here https://github.com/mozilla/sugardough/blob/master/%7B%7B%20cookiecutter.project_name%20%7D%7D/%7B%7B%20cookiecutter.project_name%20%7D%7D/base/templates/%7B%7B%20cookiecutter.project_name%20%7D%7D/home.jinja#L43 and make sure that the template is rendered correctly here https://github.com/mozilla/sugardough/blob/master/%7B%7B%20cookiecutter.project_name%20%7D%7D/%7B%7B%20cookiecutter.project_name%20%7D%7D/base/tests.py#L9?

bobsilverberg commented 9 years ago

Thanks for the review @glogiotatidis. I have added a test in my latest commit.

glogiotatidis commented 9 years ago

Tests are failing for python3

bobsilverberg commented 9 years ago

@glogiotatidis I believe all the tests are passing now. :)

bobsilverberg commented 8 years ago

@glogiotatidis: @robhudson commented [1] in the One and Done commit where I added this that there is, iho, a better solution [2] than this. Would you mind taking a look at that, and if you agree that we should not add the fe filter to sugardough feel free to close this PR.

[1] https://github.com/mozilla/oneanddone/pull/301/files#r45286842 [2] https://bugzilla.mozilla.org/show_bug.cgi?id=1222040

glogiotatidis commented 8 years ago

I'm super happy that somehow Will's comment reached oneanddone, now sugardough and in a moment lumbergh's https://github.com/mozilla/lumbergh/pull/140. A perfect example of how much open development rocks. You're all awesome!

Yes, newstyle gettext works better so I'm closing the PR. Thanks @bobsilverberg :gem: