search

mozilla / sumo-experiments

1 stars 5 forks source link

Negative feedback can be edited and sent again in the same session #51

Open rleitan opened 5 years ago

rleitan commented 5 years ago

[Environment]: All platforms- all browsers

[STR]: 1.Open https://support.allizom.org/en-US/kb/exp/insecure-password-warning-firefox 2.Go to "Was this article helpful?" section and click thumb down button 3.Select a radio button and add some text in the text box 4.Click Submit button 5.Click Thumb up button -> "Thank you for your feedback!" message is displayed (expected) 6.Click Thumb down button

[Expected result]: "Thank you for your feedback!" message should be displayed. New feedback should be sent only after a page refresh

[Actual result]: Selected option and the text entered in step 3 are displayed and the feedback can be submitted again

akatsoulas commented 5 years ago

@rleitan the refresh that existed in a previous iteration was in a way faked as it didn't do anything apart from reloading the page. The response is sent through ajax so no refresh is needed. Since there is a visual acknowledgement that it was successfully submitted I would suggest to close this issue. Thoughts? cc @madasan

rleitan commented 5 years ago

I filed this issue because of inconsistent behaviour between good feedback submission flow and bad feedback flow. ( positive feedback can be sent again only after a page refresh) However, if the user wants to submit new negative feedback( without refreshing the page), I think it's a controlled action.

akatsoulas commented 5 years ago

Thanks @rleitan! The behavior has been modified for both actions (up-voting/down-voting). Either page is refreshed regardless the feedback. Is this not the case here?

rleitan commented 5 years ago

https://vimeo.com/319439625 The page is not automatically refreshed anymore. up-voting can be done only after manually refresh the page and down-voting can be done again and again without refreshing the page