mozilla / sumo

Project management board for SUMO and Community properties.
Mozilla Public License 2.0
13 stars 5 forks source link

Remove trailing slash from messages urls. #1158

Closed akatsoulas closed 1 year ago

akatsoulas commented 1 year ago

https://github.com/mozilla/kitsune/pull/5336

mirunacurtean commented 1 year ago

@smithellis IF I understand this correctly, does it mean that besides new/sent/delete/bulk sections, shouldn't the trailing slash be removed from the inbox url as well? image

smithellis commented 1 year ago

Ah, I see the source of confusion. @mirunacurtean The task for me was to clean up the routes in the urls.py file by removing the leading slash, not the trailing. In some cases a trailing slash had to be added to certain routes, but that would be rare. So if existing routes/urls/clickstreams still work in the messages section, then trailing slash isn't the critical check.

mirunacurtean commented 1 year ago

Great, thank you, then I can move this to Ready for Release.