Ready for L10N column on KB dashboard should reflect only the last normal or major revision

[emilghittasv]

Describe the bug In https://bugzilla.mozilla.org/show_bug.cgi?id=1205093 users have stated that the "Ready for L10N" KB dashboard (example: https://support.mozilla.org/en-US/contributors/kb-overview?product=firefox) column is misleading and is not resembling the most recent revisions. "This makes it difficult for reviewers to find articles with approved content changes that haven't been marked ready to localize" per https://bugzilla.mozilla.org/show_bug.cgi?id=1205093#c13

Steps to reproduce Steps to reproduce the behavior:

1. Go to https://support.mozilla.org/en-US/contributors/kb-overview?product=firefox
2. Visit an article that is "Ready for L10N" like the "How to troubleshoot time related errors on secure websites" article
3. Observe the Show History section for that article.

Expected behavior The dashboard should take the following rules into consideration when deciding what status to display under the "Ready for L10N" column:

• The dashboard should consider only the last normal or major revision (not the minor ones).
• If the last normal or major revision is not ready for L10N, the "Ready for L10N" column should state "No". If it was marked as ready for L10N, the "Ready for L10N" column should state "Yes"

Actual behavior The latest revision is marked as not ready for L10N which is in contrast to what the dashboard points out.

Screencast

Desktop:

• OS: Windows 10 64bit
• Browser: Firefox

Additional context As stated in https://bugzilla.mozilla.org/show_bug.cgi?id=1205093#c1. The current logic is to:

• Display "Yes" if the article has "any revision ready for localization"
• Display "No" If the article has "no revision ready for localization"

[MikkCZ]

5 years ago I created a small PR that should have fixed it, but it got never reviewed. Maybe it could help someone to start over. https://github.com/mozilla/kitsune/pull/3196