search

mozilla / sumo

Project management board for SUMO and Community properties.
Mozilla Public License 2.0
12 stars 5 forks source link

The close button from the "Add to Calendar" dialog is not entirely visible in some Windows and macOS high contrast modes #1515

Open emilghittasv opened 10 months ago

emilghittasv commented 10 months ago

Steps to reproduce Steps to reproduce the behavior:

  1. Navigate to https://support.allizom.org/en-US/kb/switching-devices
  2. Bring the "Add to calendar" dialog into view by adding document.querySelector("setup-device-step").openReminderDialog() inside the web console.
  3. Enable the Windows high contrast themes and toggle between them and macOS "Invert colours" option.

Expected behavior All elements from the "Add to calendar" dialog are visible.

Actual behavior The "X" close button is not entirely visible in some high contrast themes:

Windows High Contrast 1: image

Windows High Contrast 2: image

Windows High Contrast black: image

macOS Inverted colours 1698160129333

Desktop:

Additional context The "X" close button is successfully displayed in High Contrast White theme & the other options from the macOS high contrast themes.

mikeconley commented 9 months ago

Part of the issue here is that the web platform today in Firefox does not give us reliable means to detect HCM dark/light on Windows. This is changing with https://bugzilla.mozilla.org/show_bug.cgi?id=1789214, which should hit the release channel on December 19th. After that, we can probably have this fixed for the people who are using Firefox >= 121.

Users on versions < 121 will, unfortunately, still hit this.