mozilla / sumo

Project management board for SUMO and Community properties.
Mozilla Public License 2.0
12 stars 5 forks source link

Some SUMO strings are not marked as localizable #1889

Open emilghittasv opened 1 month ago

emilghittasv commented 1 month ago

Some strings throughout SUMO are not marked as localizable. Not having those strings published & translated in Pontoon makes the affected SUMO areas to display mixed locale (English + non-English words for non-English users) content.

Here is a list with some examples:

Moderate Forum Content (/flagged)

Forums

Media Gallery

Badges /badges/

Profiles

Product topics listing page

Browse all forum threads by topic

All topics dropdown option (https://github.com/mozilla/kitsune/blob/ae43b3b20af1ef3625a948beb25be3c35d697ec0/kitsune/products/jinja2/products/includes/product_macros.html#L33)

Explore by topic

All topics dropdown option (https://github.com/mozilla/kitsune/blob/ae43b3b20af1ef3625a948beb25be3c35d697ec0/kitsune/products/jinja2/products/includes/product_macros.html#L33)

Posted Question page

General

janbrasna commented 1 month ago

I've coincidentally run into some of the issues recently and opened them separately not aware of the more epic overview here. I'd still have addressed some of them individually anyways, instead of a more holistic approach, as the occurrences I opened PRs for were a) the most visible for majority of visitors, b) had the issue/surface clearly defined as the strings were already being localised, and successfully used in other places, so the path to fix was very straightforward.

That said I believe the "… by topic" All Topics placeholder should be fixed now in lieu of #1890 as that seems to be using the same macro.

janbrasna commented 1 month ago

I've run into more places, however unable to pinpoint where that comes from. I see e.g. the "Troubleshooting" description in https://support.mozilla.org/de/topics/troubleshooting "Discover solutions for common issues and explore best practices to diagnose and resolve problems." in English everywhere too.

Or the string "Version" in version list dropdown in "Customize this article" e.g.: https://support.mozilla.org/ja/kb/tabs-organize-websites-single-window here in the sidebar.

janbrasna commented 1 month ago

There's also a few more reported by the members: https://support.mozilla.org/en-US/forums/contributors/717059?last=87867#post-87867

2024-07-20-08-58-08-f8458b