Open emilghittasv opened 1 month ago
I've coincidentally run into some of the issues recently and opened them separately not aware of the more epic overview here. I'd still have addressed some of them individually anyways, instead of a more holistic approach, as the occurrences I opened PRs for were a) the most visible for majority of visitors, b) had the issue/surface clearly defined as the strings were already being localised, and successfully used in other places, so the path to fix was very straightforward.
That said I believe the "… by topic" All Topics placeholder should be fixed now in lieu of #1890 as that seems to be using the same macro.
I've run into more places, however unable to pinpoint where that comes from. I see e.g. the "Troubleshooting" description in https://support.mozilla.org/de/topics/troubleshooting "Discover solutions for common issues and explore best practices to diagnose and resolve problems." in English everywhere too.
Or the string "Version" in version list dropdown in "Customize this article" e.g.: https://support.mozilla.org/ja/kb/tabs-organize-websites-single-window here in the sidebar.
There's also a few more reported by the members: https://support.mozilla.org/en-US/forums/contributors/717059?last=87867#post-87867
Some strings throughout SUMO are not marked as localizable. Not having those strings published & translated in Pontoon makes the affected SUMO areas to display mixed locale (English + non-English words for non-English users) content.
Here is a list with some examples:
Moderate Forum Content (/flagged)
The
View
button:The
Edit
button:The
Update
button: https://github.com/mozilla/kitsune/blob/f2d5e5a17aba6224b87d094228aa3da77a386457/kitsune/flagit/jinja2/flagit/queue.html#L34Forums
breadcrumbs
,forum title
,subtitles
for https://support.allizom.org/de/forums/contributors/, https://support.allizom.org/de/forums/social-media/, https://support.allizom.org/de/forums/support-forum-contributors/, https://support.allizom.org/de/forums/l10n-forum/, https://support.allizom.org/de/forums/mobile-support/, https://support.allizom.org/de/forums/knowledge-base-articles/, https://support.allizom.org/de/forums/forum-moderators/, https://support.allizom.org/de/forums/off-topic/ and https://support.allizom.org/de/forums/lost-threads/Edit thread title
is not available in pontoon for translation and is displayed in English on thede
version of SuMo (https://github.com/mozilla/kitsune/blob/f2d5e5a17aba6224b87d094228aa3da77a386457/kitsune/forums/jinja2/forums/edit_thread.html#L13) -> https://pontoon.mozilla.org/de/sumo/LC_MESSAGES/django.po/?search=Edit+thread+titleTitle
andContent
strings from https://support.allizom.org/de/forums/contributors/newReplies
from a posted forum thread with at least one reply (https://github.com/mozilla/kitsune/blob/f2d5e5a17aba6224b87d094228aa3da77a386457/kitsune/forums/jinja2/forums/posts.html#L24)Move Thread
(https://github.com/mozilla/kitsune/blob/f2d5e5a17aba6224b87d094228aa3da77a386457/kitsune/forums/jinja2/forums/posts.html#L134)Search this forum
placeholder is marked as localizable (https://github.com/mozilla/kitsune/blobae43b3b20af1ef3625a948beb25be3c35d697ec0/kitsune/forums/jinja2/forums/threads.html#L43 ( but the string is not displayed in Pontoon (example for thede
locale: https://pontoon.mozilla.org/de/sumo/LC_MESSAGES/django.po/?search=Search+this+forum)Media Gallery
Browse...
button (https://github.com/mozilla/kitsune/blob/c4eb68b1d544a9a54fba774da05b80b30eb28a09/kitsune/upload/jinja2/upload/attachments.html#L48)Badges /badges/
Profiles
Cancel
button from the /users/edit page (https://github.com/mozilla/kitsune/blob/22e7c994b686274846d10eb24db68b8053fce4cc/kitsune/users/jinja2/users/edit_profile.html#L80)Product topics listing page
More
option form the product subtopic list (https://github.com/mozilla/kitsune/blob/ae43b3b20af1ef3625a948beb25be3c35d697ec0/kitsune/questions/jinja2/questions/question_list.html#L315)Browse all forum threads by topic
All topics
dropdown option (https://github.com/mozilla/kitsune/blob/ae43b3b20af1ef3625a948beb25be3c35d697ec0/kitsune/products/jinja2/products/includes/product_macros.html#L33)Explore by topic
All topics
dropdown option (https://github.com/mozilla/kitsune/blob/ae43b3b20af1ef3625a948beb25be3c35d697ec0/kitsune/products/jinja2/products/includes/product_macros.html#L33)Posted Question page
Add a tag
option from the posted question (https://github.com/mozilla/kitsune/blob/ae43b3b20af1ef3625a948beb25be3c35d697ec0/kitsune/questions/jinja2/questions/question_details.html#L425)when anybody replies
(https://github.com/mozilla/kitsune/blob/ae43b3b20af1ef3625a948beb25be3c35d697ec0/kitsune/questions/jinja2/questions/includes/email_subscribe.html#L19)when a solution is found
(https://github.com/mozilla/kitsune/blob/ae43b3b20af1ef3625a948beb25be3c35d697ec0/kitsune/questions/jinja2/questions/includes/email_subscribe.html#L23)General
Show More
option from the side navbar in: https://support.allizom.org/en-US/gallery/images, https://support.allizom.org/en-US/contributors, https://support.allizom.org/en-US/kb/revisions, (https://github.com/mozilla/kitsune/blob/ae43b3b20af1ef3625a948beb25be3c35d697ec0/kitsune/sumo/jinja2/includes/common_macros.html#L915)Learn More
button from the avoid scam banner (https://github.com/mozilla/kitsune/blob/ae43b3b20af1ef3625a948beb25be3c35d697ec0/kitsune/sumo/jinja2/includes/common_macros.html#L46) -> Fixed in https://github.com/mozilla/sumo/issues/1887