search

mozilla / sumo

Project management board for SUMO and Community properties.
Mozilla Public License 2.0
14 stars 5 forks source link

UI issues displayed for the "Clear All" button from the "Restrict Visibility" section #2029

Closed emilghittasv closed 3 weeks ago

emilghittasv commented 3 weeks ago

Preconditions Sign in to SUMO with an account that has the proper permission of restricting the visibility of a KB article.

Steps to reproduce Steps to reproduce the behavior:

  1. Go to any kb article.
  2. Click on the "Edit Article Metadata" option from the "Editing Tools" side navbar.
  3. Add a group inside the "Restrict Visibility" section.
  4. Observe the "Clear all" button.

Expected behavior No UI issues displayed.

Actual behavior The "Clear all" button is not properly displayed.

Screencasts ClearAll

Desktop (please complete the following information):

Additional context This issue is reproducible in stage only.

akatsoulas commented 3 weeks ago

This is the default design of the library. We can add a ticket to override it but this is not a bug

https://tom-select.js.org/plugins/clear-button/

emilghittasv commented 3 weeks ago

Thanks! @akatsoulas

I think that we should consider overriding it. Even if that's the default style. It looks broken & could generate user confusion.

Would you like me to morph this ticket? or do you prefer keeping track of the override somewhere else?

akatsoulas commented 3 weeks ago

Let's track this in a different issue. Since this is not considered a bug, it won't be part of this sprint