mozilla / sumo

Project management board for SUMO and Community properties.
Mozilla Public License 2.0
14 stars 5 forks source link

Navigating to the /group/avatar page will yield the "This field is required." error directly #2055

Open emilghittasv opened 1 week ago

emilghittasv commented 1 week ago

Preconditions Sign in to SUMO with an account that has the proper permissions of changing a group avatar.

Steps to reproduce Steps to reproduce the behavior:

  1. Go to https://support.allizom.org/en-US/groups/
  2. Click on any of the available groups which don't have an avatar uploaded yet.
  3. Click on the "Change" option from the avatar section.

Expected behavior The "This field is required." error message should be displayed only if the user clicks on the "Upload" button without having an image attached.

Actual behavior The "This field is required." error message is displayed immediately as the change avatar page loads.

Screencasts fieldRequiredv2

Desktop:

Additional context This issue is reproducible in stage only.

emilghittasv commented 1 week ago

@smithellis I'm wondering if we could also change the This field is required error to something more meaningful like the one we have in https://github.com/mozilla/sumo/issues/2021#issuecomment-2476229572 (You have not selected an image to upload)