Run `feature.shutdown()` before unloading the JSM file

mozilla / taar-experiment-v3-shield-study

Shield Study Add-on for TAAR Experiment v3

https://docs.google.com/document/d/1r8RC8BBjS9DQSBfanlD-MlCS4XWN3-bozyWOIFlD8aA/edit

Mozilla Public License 2.0

2 stars 11 forks source link

Run `feature.shutdown()` before unloading the JSM file #11

Closed Dexterp37 closed 6 years ago

Dexterp37 commented 6 years ago

I filed this issue here: mozilla/shield-studies-addon-template#44.

Depending on what you're doing during shutdown, the procedure might be failing because the dependencies are getting unloaded before the shutdown method gets called, see here.

This is potentially not being trigger as the shutdown procedure might not be called at all due to this.

motin commented 6 years ago

Thanks, this has been addressed in 09d17fc835e5969d273ecc8ef02afb0224ea181c and d5ebdee86eba08cf9a55970ed5d573bbd62d8391