search

mozilla / taar-lite

A lightweight version of the TAAR service intended for specific deployments with reduced feature visibility.
Mozilla Public License 2.0
2 stars 6 forks source link

Taar whitelist is not filtering out legacy addons #18

Closed crankycoder closed 6 years ago

crankycoder commented 6 years ago

The TAAR dump is a complete list of addons, however that also includes legacy addons which no longer work post Fx57.

The taar whitelist needs to add an extra filter for is_webextension checking that this is set to true.

crankycoder commented 6 years ago

This patch is in https://github.com/mozilla/python_mozetl/pull/227

mlopatka commented 6 years ago

Just a point of clarification wrt this patch. In the current ETL flow, is the whitelist applied early enough that the coinstallation counts are not being skewed byut the presence of legacy addons?

The bottom line: is whitelist verification happening as early as it possible can be?

mlopatka commented 6 years ago

Answering my own question here... whitelist comparison is happenign as early as possible. Coinstilation aggregation is happening only on whitelisted addons (non-whitelist addons are removed from client information as early as possible).

When PR#227 lands we can close this issue.