mozilla / taar-lite

A lightweight version of the TAAR service intended for specific deployments with reduced feature visibility.
Mozilla Public License 2.0
2 stars 6 forks source link

added redis caching and updated testcases #25

Closed crankycoder closed 6 years ago

crankycoder commented 6 years ago

This adds a redis cache around JSON loads from S3.

Review notes:

The lines in _get_json that check the ignore_redis() flag are a bit ugly.

crankycoder commented 6 years ago

@birdsarah this should be a lot better. The test_cache testsuite tests just the hot and cold redis cache state.

The test_guidbased_recommender module was modified to just add an extra argument to the install_mock_data function for each testcase to explicitly set the redis cache to a cold state.