@crankycoder - I've scheduled a meeting to talk about this and more.
This is not as bad as it looks. It's mostly an epic code reshuffle that chiefly:
1) breaks out production details such as loading things from S3 and cacheing them etc
2) breaks out Treatment classes from a Recommender class
You'll find your API largely unchanged. I did this so that I could run all your tests without changing them and check everything's still passing. That has worked with two exceptions: there are two tests that I've skipped as the _guid_maps implementation has gone.
I will re-write these tests after checking in with you.
Then after this merge would suggest that I follow-up with:
1) a rename, or perhaps even complete move, of the production module
2) a test shuffle to reflect the new structures under recommenders
Also worth noting this would break taar-lite-api if merged as location of GuidBasedRecommender has moved.
@crankycoder - I've scheduled a meeting to talk about this and more.
This is not as bad as it looks. It's mostly an epic code reshuffle that chiefly: 1) breaks out production details such as loading things from S3 and cacheing them etc 2) breaks out Treatment classes from a Recommender class
You'll find your API largely unchanged. I did this so that I could run all your tests without changing them and check everything's still passing. That has worked with two exceptions: there are two tests that I've skipped as the _guid_maps implementation has gone.
I will re-write these tests after checking in with you.
Then after this merge would suggest that I follow-up with: 1) a rename, or perhaps even complete move, of the production module 2) a test shuffle to reflect the new structures under recommenders
Also worth noting this would break taar-lite-api if merged as location of GuidBasedRecommender has moved.