search

mozilla / taar-lite

A lightweight version of the TAAR service intended for specific deployments with reduced feature visibility.
Mozilla Public License 2.0
2 stars 6 forks source link

Are the ranking strings used for anything other than sorting? #42

Open birdsarah opened 6 years ago

birdsarah commented 6 years ago

Wondering if we can just return a sorted list (and start thinking about different ways to return that list) or if the actual string ('guid-1', '000000000.2666666667.0000000010') that is the second item in the tuple is used elsewhere?

dzeber commented 6 years ago

+1 - I think explicit sorting on two keys would make clearer what the logic is, unless this breaks something else.

birdsarah commented 6 years ago

ping @mlopatka @vng

vng commented 6 years ago

Why are you guys notice me on this mozilla's issues? This is the third time already for the last month :)

dzeber commented 6 years ago

@vng sorry about that! Your handle is the same as the one our colleague uses internally at Mozilla...

dzeber commented 6 years ago

ping @crankycoder

birdsarah commented 6 years ago

@vng sorry about that! Your handle is the same as the one our colleague uses internally at Mozilla...

Yes. So sorry I will try and keep the two separated.

birdsarah commented 5 years ago

Discussed on Sep 10. We do not need to return ranking string. (So tie breaking can be a Treatment). It is not used elsewhere. Agreed to stop returning it from recommend funciton. Recommend function will only return a list of guids.