search

mozilla / tab-split

A magical place for tabs and tabs
https://testpilot.firefox.com
Mozilla Public License 2.0
3 stars 6 forks source link

Limit split to one tab and match tab UI to spec #29

Open johngruen opened 6 years ago

johngruen commented 6 years ago

@chenmorpheus

in the visual spec it looks like you have specific color requirements for split tab UI, but what about on the second split pair, or third etc..?

https://mozilla.github.io/testpilot-assets/Tab_Split/Tab_Split_visual_spec/#artboard1

fzzzy commented 6 years ago

Currently, every new tab pair gets a random color.

ChenMorpheus commented 6 years ago

@johngruen @fzzzy @ianb From lean UX perspective, I decided to allow users to create only one set of grouped tabs. Sorry that I didn't document our decision somewhere which got you guys confused with the current implementation.

The assumption of TS is to ensure the existed needs of multitasking, and TS could be a valued solution. As a result, I believe providing only one set of grouped tabs could simplify the user experience and use cases, and reduce as much time and resource cost as possible. Once assumption validated, we could fine tune the UX and provide the ability of more sets of grouped tabs.

As for the current implementation, Fischer just wanted to try the ability to allow more sets of grouped tabs, but we all agreed to limit the number to one set for the first version.

johngruen commented 6 years ago

IDK if there's any real value in reducing the number of splits at this point. Might be more engineering work to undo this...we will decide in standup tomorrow.

ChenMorpheus commented 6 years ago

@johngruen So the conclusion was to allow users create more than one set of split tabs now, right?