Closed schalkneethling closed 9 years ago
We don't have much in the .gruntfile just yet, any reason not to start off be using Gulp?
Is Gulp the new hotness ;) Used to using Grunt for all the things but, no reason we cannot use Gulp.
Is Gulp the new hotness ;) Used to using Grunt for all the things but, no reason we cannot use Gulp.
Entirely up to you on this one, they both work well for projects like this :+1:
Hey, I like learning new things so, let me Gulp it up :runner:
+1 for Gulp, and keeping lib.less
as slim as possible.
@jpetto both === done ;)
Should we add a default gulp task? (maybe just runs watch
?)
Other than the points mentioned above, this looks good to me :+1:
Yeah sure, let's do that re: default gulp task.
@alexgibson Good to merge? The only potential problem here is the commit messages. I stupidly :blush: worked directly on master on my fork so, not sure how I can squash all these commits :cry:
You can do "git rebase -i
Thanks @willkg however, I get this when I attempt a git rebase -i https://sneethling.pastebin.mozilla.org/8839482
If you have 11 commits, try git rebase -i HEAD~11
?
Bah. fucking github comments. I wrote git rebase -i <sha>
and it nixed the sha part.
w00t!!! Thanks @willkg and @alexgibson now I have learned some new git foo \o/
LGTM, r+! :pineapple:
@alexgibson r?