mozilla / tabzilla

Universal Tab for Mozilla websites
Mozilla Public License 2.0
74 stars 46 forks source link

Fix Bug 1151579 - New Tabzilla v0.3.0 static package #54

Closed schalkneethling closed 9 years ago

schalkneethling commented 9 years ago

@alexgibson r?

alexgibson commented 9 years ago

We don't have much in the .gruntfile just yet, any reason not to start off be using Gulp?

schalkneethling commented 9 years ago

Is Gulp the new hotness ;) Used to using Grunt for all the things but, no reason we cannot use Gulp.

alexgibson commented 9 years ago

Is Gulp the new hotness ;) Used to using Grunt for all the things but, no reason we cannot use Gulp.

Entirely up to you on this one, they both work well for projects like this :+1:

schalkneethling commented 9 years ago

Hey, I like learning new things so, let me Gulp it up :runner:

jpetto commented 9 years ago

+1 for Gulp, and keeping lib.less as slim as possible.

schalkneethling commented 9 years ago

@jpetto both === done ;)

alexgibson commented 9 years ago

Should we add a default gulp task? (maybe just runs watch?)

alexgibson commented 9 years ago

Other than the points mentioned above, this looks good to me :+1:

schalkneethling commented 9 years ago

Yeah sure, let's do that re: default gulp task.

schalkneethling commented 9 years ago

@alexgibson Good to merge? The only potential problem here is the commit messages. I stupidly :blush: worked directly on master on my fork so, not sure how I can squash all these commits :cry:

willkg commented 9 years ago

You can do "git rebase -i " and pick a sha that's the point where you should have had your branch diverge at. That puts you in a mode where you can selectively squash, fixup, reword, etc the commits.

schalkneethling commented 9 years ago

Thanks @willkg however, I get this when I attempt a git rebase -i https://sneethling.pastebin.mozilla.org/8839482

alexgibson commented 9 years ago

If you have 11 commits, try git rebase -i HEAD~11?

willkg commented 9 years ago

Bah. fucking github comments. I wrote git rebase -i <sha> and it nixed the sha part.

schalkneethling commented 9 years ago

w00t!!! Thanks @willkg and @alexgibson now I have learned some new git foo \o/

alexgibson commented 9 years ago

LGTM, r+! :pineapple: