search

mozilla / teach-api

A basic API to store data for learning.mozilla.org
2 stars 11 forks source link

Error messages when updating Club applications #57

Closed KGorr closed 8 years ago

KGorr commented 8 years ago

When I mark a club as approved or denied, there are 9 error messages that appear that say certain fields are required:

occupation hosting reason how they heard venue frequency age range club size member occupation club topics

I have to type in n/a in each field in order to save the approval/denial.

CC @hannahkane

Pomax commented 8 years ago

This might be caused by https://github.com/mozilla/teach-api/blob/master/clubs/admin.py, let me see if we can extend that to include the new column values.

edit: hm, no this file seems only related to Excel exports.

Pomax commented 8 years ago

@KGorr is this for a new application, or for an older application (older applications need "something" in those fields in order to conform to the set of fields that the new club form asks for)

KGorr commented 8 years ago

screen shot 2016-08-08 at 9 30 11 am

Pomax commented 8 years ago

After some checking, the reason we're seeing this is that these are older applications that need to be uplifted to the new application schema - there's a few more fields that for old applications will not exist, and so the admin panel is asking the editing admin to give these fields real values before it'll save.

This will stay the case for any application prior to August 5th, but we might be able to do a batch update of the older club application so that all these "now required" fields are set to "n/a" or a similar string, so that we won't have to fill in these fields with throwaway content just to approve or deny an old club application.

As we've found the problem here I will close this issue, but I've filed https://github.com/mozilla/teach-api/issues/59 to track the possibility of batch updating the database to remove the painpoint here.