mozilla / telemetry-dashboard

Web-frontend for aggregated telemetry data

telemetry.mozilla.org

Other

89 stars 113 forks source link

Fix #521 : The description text and detail link should have a smaller (normal) font size in Measurement Dashboard #523

Closed Sylvia23 closed 6 years ago

Sylvia23 commented 6 years ago

406 #501 For a better user experience, the description text and detail link should have a smaller (normal) font size in Measurement Dashboard.

One file is affected dashboards.css. Here is the live link.

@georgf Please review. Thanks!

georgf commented 6 years ago

@Sylvia23 i don't see a smaller font-size under the live-link for descriptions, is this the right link?

Sylvia23 commented 6 years ago

Yes @georgf ! Actually I will make it live after #525 . Sorry for the inconvenience. Thanks!

georgf commented 6 years ago

Sure, no worries!

Sylvia23 commented 6 years ago

@georgf Here is the live link. Please review. Thanks!

georgf commented 6 years ago

Thanks. Looking at the live link, the descriptions still have the larger font. I used the inspector (right click, inspect element) to check the styles for the element. I found that the font-size gets overridden:

screen shot 2018-04-11 at 20 38 26

screen shot 2018-04-11 at 20 38 06

Sylvia23 commented 6 years ago

@georgf Yes, I missed that. Now, I have set the font-size as medium. Does it look nice or you want any other size. Here is the live link to check this. Thanks!