search

mozilla / telemetry-dashboard

Web-frontend for aggregated telemetry data
telemetry.mozilla.org
Other
91 stars 114 forks source link

Probe dictionary stats should only count "release" probes for release channel #526

Closed georgf closed 6 years ago

georgf commented 6 years ago

In the stats view, we currently count all the probes for the release channel. We don't record all of them there, so we should show only count the "release" probes.

Compare e.g. the count here (55) with the count here (>1.8k for version 59).

Insiyaa commented 6 years ago

Can you please explain a bit more?

Sylvia23 commented 6 years ago

@Insiyaa According to my understanding, the issue says that when the view is set to stats, the Count of recorded probes displays as 1.8k probes for version 59 while the actual count is 550 for version 59 as shown in the screen-shot attached below. Please have a look. Hence, there is some bug which counts for all values even when the channel is set to release and gives a high value ie 1.8k. So, we should make them equal and show the actual count ie 550 in the histogram ie stats view as well. Does that help? imageedit_2_8936431124 imageedit_3_7244767032

@georgf Did I get that right? Please clarify. Thanks!

Insiyaa commented 6 years ago

@Sylvia23 Thanks:)! I'll try to look into this!

Sylvia23 commented 6 years ago

Cool. Cheers !

Insiyaa commented 6 years ago

Is something like this expected? @georgf moz0

georgf commented 6 years ago

Yes, this is exactly what i would expect! It would be nice to change the style (only show blue bars for this case), but that is just a cosmetic issue :)

Insiyaa commented 6 years ago

Yes will do that! And what is to be done with the legend? Is it to be removed?

georgf commented 6 years ago

We could leave it, but only show "optout". Does that sound good?

Insiyaa commented 6 years ago

Yea okay!