mozilla / telemetry-dashboard

Web-frontend for aggregated telemetry data
telemetry.mozilla.org
Other
91 stars 114 forks source link

Add some tooltips to probe dictionary fields #566

Closed georgf closed 6 years ago

georgf commented 6 years ago

Start adding some tooltips to some probe dictionary fields. These try to explain some of the potentially less clear fields.

georgf commented 6 years ago

This is live for testing here.

Dexterp37 commented 6 years ago

@georgf , I don't want to sound picky on this, so pardon me :) I was thinking that maybe we should suggest users that there is a "tooltip", otherwise it's not easy to know. What about we add tooltip only on the headers and add a dashed underline where there's a tooltip? As shown here.

georgf commented 6 years ago

Wouldn't it make more sense to change the text per probe to be more specific, e.g. release -> "This probe is only collected on Firefox release channel", pre-release -> "This probe is only collected on Firefox pre-release channels (beta & nightly)

This sounds great, i'd take that to future improvements though as it's more work. Having some static tooltips is better than having none.

georgf commented 6 years ago

@georgf , I don't want to sound picky on this, so pardon me :) I was thinking that maybe we should suggest users that there is a "tooltip", otherwise it's not easy to know. What about we add tooltip only on the headers and add a dashed underline where there's a tooltip? As shown here.

It doesn't sound picky & good points. From user conversations and watching someone try this out, having tooltips around the place of confusion is important. Underlining seems a bit noisy (visually) to me. I was thinking maybe adding a subtle info circle icon in a follow-up to aid discovery?

Dexterp37 commented 6 years ago

Underlining seems a bit noisy (visually) to me. I was thinking maybe adding a subtle info circle icon in a follow-up to aid discovery?

This sounds like a good compromise to me!

georgf commented 6 years ago

@badboy @Dexterp37 ready for another look