search

mozilla / telemetry-dashboard

Web-frontend for aggregated telemetry data
telemetry.mozilla.org
Other
89 stars 113 forks source link

Implemented aggregate values instead of the keys in the Evolution dashboard URL #574

Closed ab0092 closed 6 years ago

chutten commented 6 years ago

Ah-ha, I knew I was missing something.

Sorry for the delay, I was out of the office last week. I'll take a look at this today.

ab0092 commented 6 years ago

No issues. Please have a look and let me know if any tweaks are required.. Thanks.

ab0092 commented 6 years ago

@chutten i have implemented the backward compatibility option and also formatted the code accordingly. Please have a look if anything more is to be added.

ab0092 commented 6 years ago

@chutten i have added the required changes. And thanks for the above code snippet idea. It really makes it more understandable and clean. :-)

chutten commented 6 years ago

Looks good, works well, and I confirm that old-type "bucket-0!bucket-4"-type urls like this one are compatible with the new logic.

Good work!

chutten commented 6 years ago

And that should be that. Have an eye on what you'd like to work on next?

ab0092 commented 6 years ago

@chutten i have not yet been able to look at the open issues in details so could you suggest one which is having an higher priority ?? Or else i will have a look at the open tickets and decide.

chutten commented 6 years ago

Take your pick, there are none that are immediately pressing at this moment.

ab0092 commented 6 years ago

570 is an issue i had inquired about but did not receive any update so if you could provide me some details then we are good to go. We can discuss the rest on that thread itself.