search

mozilla / telemetry-dashboard

Web-frontend for aggregated telemetry data
telemetry.mozilla.org
Other
89 stars 113 forks source link

Dev edition charts show up as "aurora" in chart labels #575

Closed robhudson closed 4 years ago

robhudson commented 6 years ago

Visit https://mzl.la/2BaArYT and hover the chart lines and look at the labels. Since the front-end is already changing "Aurora" to "Dev Edition" elsewhere I propose the front-end does the string swap here as well.

shiri1248 commented 6 years ago

I would like to work on this.

shiri1248 commented 6 years ago

can anyone guide me on this issue please

chutten commented 6 years ago

Yes. The code controlling what plots look like can be found in new-pipeline/src/dist.js and new-pipeline/src/evo.js. Any time it uses the word "aurora" in a place where it might be shown to a user it should instead read "dev edition"

shiri1248 commented 6 years ago

Thanks @chutten , so I should replace the word "aurora" to "dev edition" am I right?

chutten commented 6 years ago

Correct.

shiri1248 commented 6 years ago

@chutten submitted a PR #576 please review and if you find any conflicts please let me know

hardik25 commented 5 years ago

@chutten

How to reproduce this issue?

hardik25 commented 5 years ago

Hi @chutten

I have created a pull request with fix to this issue. Please review.

driver-by commented 4 years ago

Hi guys, I've submitted a PR #629 to fix the issue. Waiting for review. Thanks!