Closed chutten closed 5 years ago
@chutten
I would like to work on this issue. From initial triaging, I could locate the part of code which will display the "no data" message. Below is the part of code that I found in the function displaySingleHistogramSet in dist.js:
Could you please confirm if I am on the right track?
Also, how could I test my fixes?
Thanks!
Sorry for the delay, I was out for the week.
Yes, that is exactly the "no data" message we hope to trigger! You can test your fix by loading the Measurement Dashboard and choosing DEVTOOLS_FLEXBOX_HIGHLIGHTER_TIME_ACTIVE_SECONDS
as the metric you'd like to display. Check the devtools console for a TypeError. If there is one, the problem persists.
Unassigning due to inactivity.
In the event that a metric has no data to show (like Nightly 66's DEVTOOLS_FLEXBOX_HIGHLIGHTER_TIME_ACTIVE_SECONDS when "sanitize data" is true), then we error to the log
And the view remains on the previous data, whatever it was. We -do- have the ability to show "no data for these options" views via metricsgraphics, so we should probably do that instead of silently throwing a fit.