search

mozilla / telemetry-dashboard

Web-frontend for aggregated telemetry data
telemetry.mozilla.org
Other
89 stars 112 forks source link

Color aggregate lines the same across versions #631

Open jonco3 opened 4 years ago

jonco3 commented 4 years ago

At present it can be confusing looking at evolution graphs because the individual aggregates get assigned different line colors for different versions, e.g.:

Screenshot_2019-11-04 Evolution Dashboard

I'm not sure whether that's exactly what this issue is talking about but it may be: https://github.com/mozilla/telemetry-dashboard/issues/625

These changes fix this by removing the version component from Line.getStateString and renaming it to Line.getColorId (this is the only use of that method).

chutten commented 4 years ago

I do indeed believe that this is #625

We might not wish to do this for the submission date view, as the same submission date can have multiple versions (the same x value can have multiple data points) for a single aggregate. See, for instance this.

How bad would it look in the code if we only turned to this mode for submission date view?