Update channel topic when Test Day starts and ends

mozilla / testdaybot

Mozilla QA Test Day IRC Bot

9 stars 12 forks source link

Update channel topic when Test Day starts and ends #34

Closed galgeek closed 9 years ago

galgeek commented 9 years ago

hi @whimboo !

with apologies for the untidy commit list, suspecting this requires re-forking the repo to fix, and not sure what that would do to existing pull requests. This will fix issue #31.

galgeek commented 9 years ago

hi @whimboo !

thanks for your feedback. I've tidied up the commits, but I haven't made any other changes: I have been thinking that the bot runs in qa, though it also advertises in other channels. fennecbot similarly runs in mobile while it advertises in several other channels. Should this bot be different?

galgeek commented 9 years ago

hi @whimboo ! thanks for your feedback. I've updated variable names. config.channels gets used to configure the client, which expects an array, so we can't easily make this simpler.

whimboo commented 9 years ago

Also I think at the moment the bot waits for an activity in the channel before it updates the topic of the channel when the testday is about to start. Shouldn't this be handled with a timer event or such?

galgeek commented 9 years ago

hi @whimboo

a biggish update, now using setTimeout to start and end test day, and other updates per your recent feedback

thank you!

galgeek commented 9 years ago

Hi @whimboo

I've updated per your comments, including adding issue #43 save and reload test day schedule across bot restarts.

Note that current code accepts the :next admin command only when a test day is not in progress, so I've made no changes to clearTimeout there.

galgeek commented 9 years ago

Hi @whimboo!

I've rebased and added test and qa config files.

I've left this version of the bot running using the test config, with a test Test Day scheduled for 6A-10A UTC. I'll check that it starts before I go to sleep, and maybe you'll have a chance to check that it's still running fine in the morning CET.

Thank you!

galgeek commented 9 years ago

Hi @whimboo!

I've removed the testing configs from the repo and updated .gitignore, and I've updated the PR.

I'm leaving any additional changes to updateTestDayData for later.

Thank you!

galgeek commented 9 years ago

Hi, @whimboo!

As we noted in IRC, I've updated this PR, backing out the .gitignore edits.

Thank you!

Barbara

whimboo commented 9 years ago

This PR needs to be updated due to merge conflicts.

galgeek commented 9 years ago

Hi @whimboo!

I've updated.

Thank you again for all your help!

whimboo commented 9 years ago

This looks good to me. I rebased the commits and merged the branch as https://github.com/mozilla/testdaybot/commit/e38ec3ae5b32984fe4bf26e90637cdf6cb40f077.