search

mozilla / testdaybot

Mozilla QA Test Day IRC Bot
9 stars 12 forks source link

Add start/end/topic to stats output #40

Closed galgeek closed 9 years ago

galgeek commented 9 years ago

hi @whimboo !

This patch adds start, end, etherpad, and topic properties to metrics object when we reset data for a new test day, so that they'll be available to generateStats and saved with metrics, until the next test day begins, addressing my comment in issue #23.

whimboo commented 9 years ago

Not sure why this PR was asked for review already given that it misses most of the requirements as given on issue #23. We may go with this as round 1, but certainly have to follow-up with other PR to cover all the requirements. Please let me know.

galgeek commented 9 years ago

Hi @whimboo!

This PR is meant only to address my comment on issue #23, not the entire issue.

Do we want to do something other than send stats via IRC to the requester for round 1?

whimboo commented 9 years ago

No but see the comments about privacy and opt-out. I'm fine to get this PR landed, but we need additional fixes for the other remaining requirements.

galgeek commented 9 years ago

Hi @whimboo!

I've rebased and updated the PR.

Thank you for your feedback and help!

galgeek commented 9 years ago

Hi @whimboo!

Here's another commit backing out those .gitignore edits.

Thank you!

Barbara

whimboo commented 9 years ago

I rebased the commit, fixed the commit message and merged into master as https://github.com/mozilla/testdaybot/commit/00a1f0b1eaab5d9a307bb6495a35752377776177.