search

mozilla / testdaybot

Mozilla QA Test Day IRC Bot
9 stars 12 forks source link

Add :schedule command to provide Test Day schedule #41

Closed galgeek closed 9 years ago

galgeek commented 9 years ago

hi @whimboo !

let me know if you'd prefer to format the output otherwise.

PR per issue #20

galgeek commented 9 years ago

hi @whimboo

thanks for your feedback! I've updated and pushed another commit.

galgeek commented 9 years ago

Hi @whimboo I've updated this PR. Maybe it's ready to merge? Thank you for your feedback!

whimboo commented 9 years ago

With those two nits fixed please squash all the commits into a single one so I can merge the branch. Thanks.

galgeek commented 9 years ago

hi @whimboo

nits fixed, and commits squashed. thank you!

whimboo commented 9 years ago

When you fix the last nit and rebase again, please also fix the commit message so it applies to our guidelines.

galgeek commented 9 years ago

Hi @whimboo!

I've updated the PR. It was missing a couple of variable declarations; I've added them, too, properly, I hope...

galgeek commented 9 years ago

Hi @whimboo!

I've rebased and updated the PR.

Thank you for your feedback and other help!

galgeek commented 9 years ago

Hi @whimboo!

I've used intro in a couple of places in that listener, so it needs to be at a higher level. I've put it at the top of the listener now, and the declaration for scheduleTimes in the :schedule block, since that's the only place it's used.

Thank you for your review and feedback!

galgeek commented 9 years ago

Hi @whimboo!

I've backed out the repo's .gitignore edits.

The listener where I've added var intro; is the only one using it for now.

Thank you for your help and feedback!

Barbara

whimboo commented 9 years ago

All fine for me except my latest comment, but which we can do later.

I rebased this PR and merged into master as https://github.com/mozilla/testdaybot/commit/13262fc3c29ab683f36211c03581ad35fa2949e5.