Allow participants to opt-out and opt-in for data collection during a testday

mozilla / testdaybot

Mozilla QA Test Day IRC Bot

9 stars 12 forks source link

Allow participants to opt-out and opt-in for data collection during a testday #46

Closed galgeek closed 9 years ago

galgeek commented 9 years ago

Hi @whimboo!

This PR renames and removes old stats variables and enables opt out from nick-identified data collection. Opt out totals are added to stats. This PR addresses issues #44 and #23 (privacy issues).

It also includes a couple of fixes for rebase errors.

galgeek commented 9 years ago

Hi @whimboo!

I've updated per your comments. On to saving some data to disk...

Thank you!

galgeek commented 9 years ago

Hi @whimboo!

I've updated this PR:

I've rewritten optOut as an array.
In a separate commit, I've removed lastQuit{} and the quit and part listeners handling it, since we're no longer greeting based on that. This will also save some memory.

galgeek commented 9 years ago

Hello @whimboo!

I've updated again... the bot can store the optout list across restarts.

Perhaps you'd prefer to include this in a separate PR?

whimboo commented 9 years ago

I've updated again... the bot can store the optout list across restarts. Perhaps you'd prefer to include this in a separate PR?

This is great but as I have told yesterday already, it has to be a separate issue and PR. So please move this out. I will wait with the review.

whimboo commented 9 years ago

Also keep in mind that we have to store most of the data in a file so it survives a restart. It will be best to combine that all in the necessary issue.

galgeek commented 9 years ago

Hi, @whimboo!

I've updated, backing out all the files code for a separate PR.

whimboo commented 9 years ago

I squashed the commits, updated the commit message, and merged the PR as https://github.com/mozilla/testdaybot/commit/c94db45aaedf9d71af8d7720b014892bef395cd3