search

mozilla / testdaybot

Mozilla QA Test Day IRC Bot
9 stars 12 forks source link

Save data and reload Test Day data across bot restarts #48

Closed galgeek closed 9 years ago

galgeek commented 9 years ago

Hi, @whimboo!

Here's a beginning for issue #43 , saving and reloading the schedule, plus support for opt out.

I'll look at saving metrics next.

Thank you for all your help!

galgeek commented 9 years ago

Hi, @whimboo and @ashughes1!

I have this update running in #testdaybotTest, and the save and reload tests are running fine for me. The bot saves the optout list, the current schedule, and the collected metrics, and reloads them after the bot restarts.

Anthony, perhaps you'll have time to take a look and let us know if there's anything vital missing?

Thank you!

galgeek commented 9 years ago

Hello, @whimboo and @ashughes1!

I’ve updated per Henrik's Friday feedback—thank you, Henrik! I've added just a couple of line notes where you had questions.

This code is running now in channel #testdaybotTest. Note that without op privileges, there'll be no topic changes. I was able to verify the topic change code works earlier.

Send :help to get a list of bot commands via private message.

ghost commented 9 years ago

Current test day data is fine to make public, maybe with the exception of the admins.

I would prefer, at least for now, if all data was only readable by the testday organizer and myself. It should be at our discretion which information is publicized. Going one step further, I would say that the bot should not share data with an organizer unless they have a registered IRC nick.

galgeek commented 9 years ago

Hi, @ashughes1 and @whimboo!

Test Day bot metrics are available only to those on the Test Day admins list and logged in to a registered IRC nick, using the :stats command via private message to the bot.

When I used "Current test day data" above, I was referring to schedule, etherpad, topic, helpers, admins for an active test day. The only bit of that we're not already publishing with the bot is the admin list, and I'm not proposing to publish that, just noting that it doesn't raise personal data protection issues.

galgeek commented 9 years ago

Hi, @whimboo!

I've pushed a couple of additional commits, addressing some of your feedback.

whimboo commented 9 years ago

I think that looks good now. Given that I cannot kill the bot and see that everything gets restored correctly, I will trust your testing.

whimboo commented 9 years ago

Commits have been squashed, the commit message updated, and the PR got merged as https://github.com/mozilla/testdaybot/commit/5ef21bad513fd5c9322d9d410a4ab4383433fc8a.