search

mozilla / testdaybot

Mozilla QA Test Day IRC Bot
9 stars 12 forks source link

Record bugs from updated firebot bug messages (#67) #69

Closed galgeek closed 9 years ago

galgeek commented 9 years ago

Hi, @whimboo!

This PR updates the match used for firebot messages to its new URL format.

This seems pretty straightforward, so I'm submitting without real testing. It would need to be tested in a channel where firebot is running, like #qa.

whimboo commented 9 years ago

I also see lines of Firebot which look like:

Bug 1120241 — NEW, %reporter% — Videos continue to play after tab is closed

Looks like those are returned when a person pasts a full URL into the channel. We wouldn't catch that yet.

galgeek commented 9 years ago

Hi, @whimboo!

I've updated the PR, so we should count only "FIXED" bugs. Is this what you wanted?

The original commit should catch all current firebot bugzilla messages, as did the earlier version.

whimboo commented 9 years ago

Not sure why you think we should only count fixed bugs. That's not what my last comment proposed. It showed that there is another format how bugs are getting printed to the channel.

galgeek commented 9 years ago

Hi, @whimboo!

The updated PR should now find and record the bug number from both this firebot message format:

https://bugzil.la/1120673 — FIXED, %email% — Fx 35 installer crashes on XP x86 SP3 at the end (creating shortcuts) if the xp firewall service is

as well as this format:

Bug 1120241 — NEW, %reporter% — Videos continue to play after tab is closed

Apologies for my confusion, and thanks for your feedback!

galgeek commented 9 years ago

Hi, @whimboo!

Thanks for your feedback—good idea!

I'll add you, @ashughes1, and Florin to firebot as possible bug senders, and run this in #testdaybotTest, beginning a little later today, for you to check out. I haven't found Florin on github; I'll look for him on IRC.

galgeek commented 9 years ago

Hi, @whimboo!

I've updated the variable name. Thanks for your feedback!

whimboo commented 9 years ago

For reference this PR is for issue #67.

whimboo commented 9 years ago

This PR has been merged as https://github.com/mozilla/testdaybot/commit/e801258e0f5988a4f4b2ee2962eb24313df0efbc. Thanks Barbara!