search

mozilla / testdaybot

Mozilla QA Test Day IRC Bot
9 stars 12 forks source link

Improve time handling in :next command #74

Closed whimboo closed 9 years ago

whimboo commented 9 years ago

From issue #52:

  1. When setting the ":next" testday make "time" errors more explicit: a) start time in the past b) start time after end time Currently we get the same generic error that time is invalid and have to hunt down where the issue is.

@FlorinMezei it would be good if you can give some examples here. Thanks.

FlorinMezei commented 9 years ago

Some simple examples:

a) start time in the past A simple check if start time is before current time - show an error saying something like: "Start time is set in the past - note that the timezone is UTC"

a) start time after end time A simple check if start time is before end time - show an error saying something like: "Start time was set after End Time"

xabolcs commented 9 years ago

Can I take this?

whimboo commented 9 years ago

Sure! ;) I assigned you now.

whimboo commented 9 years ago

PR #77 has been merged. I will get all the latest changes merged to the release branch now, so they will be active on the running testdaybot instance in #qa in a bit.