mozilla / testpilot

Test Pilot is a platform for performing controlled tests of new product concepts in Firefox
https://testpilot.firefox.com/
251 stars 123 forks source link

A few no-more-404s graduation_report HTML errors via W3's HTML validator #2195

Closed pdehaan closed 7 years ago

pdehaan commented 7 years ago

Seeing a few HTML validation errors via https://validator.w3.org/nu/#textarea for the no-more-404s.yaml graduation_report HTML:

  1. Error: Bad value 100% for attribute width on element img: Expected a digit but saw % instead. From line 21, column 3; to line 21, column 111

    figure>↩
    <img src="/static/images/experiments/no-more-404s/graduation/design-update.png" width="100%" height="auto" />↩ 
    <fi
  2. Error: Bad value auto for attribute height on element img: Expected a digit but saw a instead. From line 21, column 3; to line 21, column 111

    figure>↩
    <img src="/static/images/experiments/no-more-404s/graduation/design-update.png" width="100%" height="auto" />↩ 
    <fi
  3. Error: Bad value 100% for attribute width on element img: Expected a digit but saw % instead. From line 27, column 3; to line 27, column 104

    figure>↩
    <img src="/static/images/experiments/no-more-404s/graduation/gr-001.png" width="100%" height="auto" />↩
    <fi
  4. Error: Bad value auto for attribute height on element img: Expected a digit but saw a instead. From line 27, column 3; to line 27, column 104

    figure>↩
    <img src="/static/images/experiments/no-more-404s/graduation/gr-001.png" width="100%" height="auto" />↩
    <fi
  5. Error: Bad value 100% for attribute width on element img: Expected a digit but saw % instead. From line 32, column 5; to line 32, column 103

    gure>↩
    <img src="/static/images/experiments/no-more-404s/graduation/car.gif" width="100%" height="auto" />↩
    <
  6. Error: Bad value auto for attribute height on element img: Expected a digit but saw a instead. From line 32, column 5; to line 32, column 103

    gure>↩
    <img src="/static/images/experiments/no-more-404s/graduation/car.gif" width="100%" height="auto" />↩
    <
  7. Error: Bad value 100% for attribute width on element img: Expected a digit but saw % instead. From line 38, column 5; to line 38, column 106

    gure>↩
    <img src="/static/images/experiments/no-more-404s/graduation/gr-002.png" width="100%" height="auto" />↩
    <
  8. Error: Bad value auto for attribute height on element img: Expected a digit but saw a instead. From line 38, column 5; to line 38, column 106

    gure>↩
    <img src="/static/images/experiments/no-more-404s/graduation/gr-002.png" width="100%" height="auto" />↩
    <
  9. Error: Bad value 100% for attribute width on element img: Expected a digit but saw % instead. From line 43, column 5; to line 43, column 106

    gure>↩
    <img src="/static/images/experiments/no-more-404s/graduation/gr-003.png" width="100%" height="auto" />↩
    <
  10. Error: Bad value auto for attribute height on element img: Expected a digit but saw a instead. From line 43, column 5; to line 43, column 106

    gure>↩
    <img src="/static/images/experiments/no-more-404s/graduation/gr-003.png" width="100%" height="auto" />↩
    <
pdehaan commented 7 years ago

Similarly, the eslint-plugin-jsx-a11y module noted there was an unclosed <p> tag, and subsequently complained about a handful of <img> tags that were lacking alt="" attributes:

> jsx-a11y-test@1.0.0 test /Users/pdehaan/dev/tmp/del/jsx-a11y-test
> eslint .

/Users/pdehaan/dev/tmp/del/jsx-a11y-test/index.js
   8:3  error  img elements must have an alt prop, either with meaningful text, or an empty string for decorative images  jsx-a11y/img-has-alt
  13:3  error  img elements must have an alt prop, either with meaningful text, or an empty string for decorative images  jsx-a11y/img-has-alt
  19:3  error  img elements must have an alt prop, either with meaningful text, or an empty string for decorative images  jsx-a11y/img-has-alt
  24:5  error  img elements must have an alt prop, either with meaningful text, or an empty string for decorative images  jsx-a11y/img-has-alt
  30:5  error  img elements must have an alt prop, either with meaningful text, or an empty string for decorative images  jsx-a11y/img-has-alt
  35:5  error  img elements must have an alt prop, either with meaningful text, or an empty string for decorative images  jsx-a11y/img-has-alt

✖ 6 problems (6 errors, 0 warnings)
pdehaan commented 7 years ago

Unclosed <p> tag was at ./content-src/experiments/no-more-404s.yaml:94.

ghost commented 7 years ago

@pdehaan you still on this one? I'm going to move to in progress