search

mozilla / testpilot

Test Pilot is a platform for performing controlled tests of new product concepts in Firefox
https://testpilot.firefox.com/
250 stars 123 forks source link

Don't show TxP tour for experiments with built-in tours #2393

Closed sevaan closed 6 years ago

sevaan commented 7 years ago

TabCenter has a built-in tour for when a user first installs it. Test Pilot also shows a tour saying pretty much the same thing. Both tours are on screen at the same time.

Let's not show the TxP site tour for experiments that have built-in tours. We can leave the link to the tour in the sidebar for users who are curious before installing.

I'm not sure what other experiments currently have tours in them. @johngruen?

johngruen commented 7 years ago

@sevaan containers does, but it complements the test pilot tour, and I'd rather keep both.

For this issue, we should just add a YAML flag to optionally disable experiment tours, and set it to true for Tab Center.

lmorchard commented 7 years ago

One catch I'd throw in here is that we have a link to show the tour, and folks who haven't installed the experiment can use that to preview more about what the experiment does.

That said, I don't know if this link is all that well used or promoted.

SoftVision-PaulOiegas commented 7 years ago

@lmorchard This was the requested by Sevan in #1483. And just as a reminder, with this decision we got also a tiny bug #1965.

chuckharmston commented 6 years ago

Tab Center is no longer in Test Pilot. We can reconsider if a new experiment requires it. Closing!