mozilla / testpilot

Test Pilot is a platform for performing controlled tests of new product concepts in Firefox
https://testpilot.firefox.com/
251 stars 123 forks source link

Audit use of hard-coded production URLs #2691

Open pdehaan opened 7 years ago

pdehaan commented 7 years ago

Ref #2684

Currently we have a few places that use hardcoded production URLs, which means that we (QA) cannot always reliably verify stuff until it's already landed on production. Obviously waiting until something is deployed to production isn't always the best. Not sure if we can tweak any of these to point to the current environment, so we can test sharing and <meta> tags on dev/stage.

Most probably don't matter much (such as the xpi_url links, or package.json homepage, updateURL, or updateLink — but I'm not sure about the rest:

$ git grep "testpilot.firefox.com/" | grep -v "docs/"
WHERE WHAT
addon/package.json "homepage": "https://testpilot.firefox.com/",
addon/package.json "updateURL": "https://testpilot.firefox.com/static/addon/update.rdf",
addon/package.json "updateLink": "https://testpilot.firefox.com/static/addon/latest",
addon/tools/control-panel/templates.js xpi_url: 'https://testpilot.firefox.com/files/min-vid/min-vid-0.3.0-fx.xpi',
content-src/experiments/activity-stream.yaml xpi_url: 'https://testpilot.firefox.com/files/activitystream/latest'
content-src/experiments/cliqz.yaml xpi_url: 'https://testpilot.firefox.com/files/testpilot@cliqz.com/latest'
content-src/experiments/containers.yaml xpi_url: 'https://testpilot.firefox.com/files/@testpilot-containers/latest'
content-src/experiments/dev-example.yaml xpi_url: 'https://testpilot.firefox.com/files/@sloth/latest'
content-src/experiments/min-vid.yaml xpi_url: 'https://testpilot.firefox.com/files/@min-vid/latest'
content-src/experiments/no-more-404s.yaml xpi_url: 'https://testpilot.firefox.com/files/nomore404s/latest'
content-src/experiments/notes.yaml xpi_url: 'https://testpilot.firefox.com/files/notes@mozilla.com/latest'
content-src/experiments/page-shot.yaml xpi_url: 'https://testpilot.firefox.com/files/pageshot/latest'
content-src/experiments/pulse.yaml xpi_url: 'https://testpilot.firefox.com/files/pulse@mozilla.com/latest'
content-src/experiments/snooze-tabs.yaml xpi_url: 'https://testpilot.firefox.com/files/snoozetabs@mozilla.com/latest'
content-src/experiments/tab-center.yaml xpi_url: 'https://testpilot.firefox.com/files/tabcentertest1@mozilla.com/latest'
content-src/experiments/tracking-protection.yaml xpi_url: 'https://testpilot.firefox.com/files/blok/latest'
content-src/experiments/voice-fill.yaml xpi_url: 'https://testpilot.firefox.com/files/speaktome@mozilla.com/latest'
frontend/config.js PRODUCTION_EXPERIMENTS_URL: 'https://testpilot.firefox.com/api/experiments',
frontend/src/app/containers/SharePage.js const url = `https://testpilot.firefox.com/?utm_source=${medium}&utm_medium=social&utm_campaign=share-page`;
frontend/src/app/lib/utils.js const sourceUrl = source \|\| 'https://testpilot.firefox.com/';
frontend/tasks/content.js favicon: 'https://testpilot.firefox.com/static/images/favicon.ico',
frontend/tasks/content.js rss: 'https://testpilot.firefox.com/feed.rss',
frontend/tasks/content.js atom: 'https://testpilot.firefox.com/feed.atom',
frontend/tasks/content.js json: 'https://testpilot.firefox.com/feed.json'
frontend/tasks/content.js item.link = `https://testpilot.firefox.com/experiments/${experimentSlug}/#${slug}`;
frontend/tasks/content.js item.link = `https://testpilot.firefox.com/experiments/#${slug}`;
frontend/tasks/pages.js <link rel="canonical" href={ `https://testpilot.firefox.com/${canonical_path}` } />
groundcontrol/package.json "homepage": "https://testpilot.firefox.com/",
header-proxy/nginx.conf proxy_pass https://testpilot.firefox.com/files/;
chuckharmston commented 6 years ago

@SoftVision-PaulOiegas is this a problem you ever face anymore? Can we close this?