search

mozilla / testpilot

Test Pilot is a platform for performing controlled tests of new product concepts in Firefox
https://testpilot.firefox.com/
251 stars 123 forks source link

Refine .eslintrc rules for node vs browser JS #3228

Open lmorchard opened 6 years ago

lmorchard commented 6 years ago

As @pdehaan mentions:

What about just specifying the ESLint environment in the gulpfile.babel.js and webpack.config.js, a la / eslint-env node, browser, whatever /. Or if we want to set the node env for a directory, we could just use a nested .eslintrc file (for tests or gulp tasks or whatnot).

We've got a pretty broad set of globals and envs covering all of our JS for linting, right now. But, some JS is for the build chain in node and some are for running in the browser. Might be nice to use per-directory & file glob eslint overrides to further focus what's allowed for various source files.

lmorchard commented 6 years ago

Marking this as a good first issue in JS, because I think it could be tackled without a ton of deep knowledge into Test Pilot. Mainly just know-how in using eslint and some time spent exploring the repo

Mithilan16 commented 6 years ago

Hi! Can I take this issue?

SoftVision-PaulOiegas commented 6 years ago

Hi @Mithilan16 Go for it! 👍

siwaniagrawal commented 6 years ago

Hey, can I contribute to it?

SoftVision-PaulOiegas commented 6 years ago

@pdehaan @lmorchard ^

pdehaan commented 6 years ago

@siwaniagrawal absolutely! Let us know if you have any questions.