search

mozilla / testpilot

Test Pilot is a platform for performing controlled tests of new product concepts in Firefox
https://testpilot.firefox.com/
251 stars 123 forks source link

Idea-town dev site looks single column in latest FF Nightly #358

Closed pdehaan closed 8 years ago

pdehaan commented 8 years ago

Steps to reproduce:

blank_skitch_document

  1. Log into http://idea-town-dev.elasticbeanstalk.com/home
  2. Navigate to an experiment details page, a lahttp://idea-town-dev.elasticbeanstalk.com/experiments/universal-search

    Actual results:

idea_town Figure 1: Home page.

idea_town Figure 2: Details page.

NOTE: and because **6a68 asked this in IRC, here's my browser dimensions (1/2 screen width on a 24" Dell via my rMBP):

console.log(document.documentElement.clientWidth) // 1279px
console.log(document.documentElement.clientHeight) // 866px
pdehaan commented 8 years ago

This may be Nightly specific (but appear later in other channels). I got this installed/working today in FF Beta 44.0b9.

meandavejustice commented 8 years ago

I'm now seeing this is Firefox Dev edition

pdehaan commented 8 years ago

I too can reproduce in today's FF DevEdition 46.0a2. It was working a few minutes ago in FF DevEdition 43.x (before I upgraded).

Looks like something probably changed w/ FlexBox or something between FF43 and FF46 that is breaking our layout.

UPDATE: Definitely looks like something that changed in FF46. Didn't see anything interesting in https://www.mozilla.org/en-US/firefox/46.0a2/auroranotes/, but I haven't trolled through "the complete list of changes in this release" via Bugzilla yet. I'm guessing whatever it is, it's riding the trains and will hit the other channels soon enough.

test_pilot_-_experiments_and_spike_in_push_intermittent_failures_-_pdehaan_mozilla_com_-_mozilla_mail

test_pilot_-_experiments_and_spike_in_push_intermittent_failures_-_pdehaan_mozilla_com_-_mozilla_mail

test_pilot_-_experiments_and_spike_in_push_intermittent_failures_-_pdehaan_mozilla_com_-_mozilla_mail

johngruen commented 8 years ago

I haven't had time to investigate this, but i'm using the same flex mixin in another project and it looks fine in nightly...maybe we;re not closing a div somewhere? that can lead to this sort of chaos

pdehaan commented 8 years ago

Hhmm, I tested the full generated HTML in https://html5.validator.nu/ and it only came up with 4 errors and 2 warnings. Only potentially legit error was this:

Error: The element header must not appear as a descendant of the header element. From line 19, column 11; to line 19, column 18 <header>↩

But even when I changed that nested <header> to a <div> via devtools, it still renders as a odd vertical column.

johngruen commented 8 years ago

@pdehaan @meandavejustice basically i used 'default' when i should have used 'initial' or 'row' as the flex-direction value. PR incoming

meandavejustice commented 8 years ago

Than