mozilla / testpilot

Test Pilot is a platform for performing controlled tests of new product concepts in Firefox
https://testpilot.firefox.com/
251 stars 123 forks source link

Figure out a more robust way to do ExperimentPlatforms #3653

Open johngruen opened 6 years ago

johngruen commented 6 years ago

See conversation in #3640 for details

lmorchard commented 6 years ago

I think the tl;dr relevant part of the conversation is that we can't do simple string concatenation and still keep it localizable. (i.e. different locales want to rearrange word order, use different spacing, different characters, etc.)

Current solution is to define a separate string for every permutation of platforms so localizers can translate them all as necessary and we can still have a compact description. Alternatives could include lists, but those blow up the design layout in experiment cards.

pdehaan commented 6 years ago

What about just using icons instead of a matrix of text possibilities? I think all you'd need is distinct Apple vs Android icons instead of a generic "mobile" icon. Plus then you wouldn't need any l10n (apart from the alt="" tags for each icon for a11y). And it wouldn't take up any additional space (like my goofy list-based idea).

johngruen commented 6 years ago

@pdehaan we can only use the apple logo with the express written consent of Apple :)