mozilla / testpilot

Test Pilot is a platform for performing controlled tests of new product concepts in Firefox
https://testpilot.firefox.com/
251 stars 123 forks source link

[Legal] Inconsistency between Lockbox legal string displayed on "Featured experiment" section and "Experiment details" page #3667

Open SoftVision-PaulOiegas opened 6 years ago

SoftVision-PaulOiegas commented 6 years ago

[Affected versions]:

[Affected Platforms]:

[Prerequisites]:

[Steps to reproduce]:

  1. Open Firefox browser and navigate to `https://testpilot.dev.mozaws.net page.
  2. Observe the "Lockbox" legal string displayed under the "Get the App" green button in "Featured experiment" section.
  3. Click the "Lockbox" experiment Title / Icon / "View details" button.
  4. Observe the legal string displayed under the iOS App Store button.

[Expected result]:

[Actual result]:

[Notes]:

privacy link

KhushilMistry commented 6 years ago

Logic implemented on FeaturedExperiement Component :

https://github.com/mozilla/testpilot/blob/6755a786ea5211e9130429eedad5cbd67a301722/frontend/src/app/components/FeaturedExperiment/FeaturedButton.js#L81-L92

Logic implemented on Experiment Details Page :

https://github.com/mozilla/testpilot/blob/6755a786ea5211e9130429eedad5cbd67a301722/frontend/src/app/containers/ExperimentPage/ExperimentControls.js#L83-L110

I guess we can apply logic of Experiment Details Page on FeaturedExperiement Component. Should I work on this ?