search

mozilla / testpilot

Test Pilot is a platform for performing controlled tests of new product concepts in Firefox
https://testpilot.firefox.com/
251 stars 123 forks source link

title attributes are weird on eol branch for "eolMessageFour" #4029

Closed pdehaan closed 5 years ago

pdehaan commented 5 years ago

Notice how we only get the first word of each <a> content ("Firefox Color" turns into title="Firefox", "Side View" turns into title="Side", etc):

<p data-l10n-id="eolMessageFour">Other experiments like
  <a data-l10n-name="colorLink" ... title="⁨Firefox">⁨Firefox Color⁩</a>,
  <a data-l10n-name="sideViewLink" ... title="⁨Side">⁨Side View⁩</a>,
  <a data-l10n-name="notesLink" ... title="⁨Firefox">⁨Firefox Notes⁩</a>,
  <a data-l10n-name="priceWiseLink" ... title="⁨Price">⁨Price Wise⁩</a>, and
  <a data-l10n-name="emailTabsLink" ... title="⁨Email">⁨Email Tabs⁩</a>
will remain available to the ⁨Firefox⁩ community. If you have installed these experiments, you can continue to use them.
</p>

I'm not seeing the same behavior on "eolMessageThree", so it must be something subtle:

<p data-l10n-id="eolMessageThree">
  We've also built great new app experiences like
  <a data-l10n-name="lockboxLink" ... title="⁨Firefox Lockbox⁩">⁨Firefox Lockbox⁩</a> and
  <a data-l10n-name="sendLink" ... title="⁨Firefox Send⁩">⁨Firefox Send⁩</a>
  which continue to push ⁨Firefox⁩ beyond the browser. Look for exciting new developments from both of these projects in 2019.
</p>

I do not know if having the title="" attribute with the exact same text as the anchor text improves a11y at all, but probably worth fixing since the current behavior would be notably worse for screen readers.