search

mozilla / testpilot

Test Pilot is a platform for performing controlled tests of new product concepts in Firefox
https://testpilot.firefox.com/
250 stars 123 forks source link

Weird unicode text on page title #875

Closed ghost closed 6 years ago

ghost commented 8 years ago

Visiting experiment detail pages show weird characters in the title bar. Screenshot @ https://www.evernote.com/shard/s3/sh/bf3f2560-af38-42e2-ae87-83246ca9c3e7/ee84a96f17b0ae021559351109aabd56

This is in Nightly on Linux, although I think Nick runs windows. The original report is https://github.com/bwinton/VerticalTabs/issues/144

ghost commented 7 years ago

Experiment names are no longer in the titles, so, I guess this is fixed-ish

ghost commented 7 years ago

Experiment titles are back now and so is this bug...

mathieuinottawa commented 7 years ago

Looks different to me, but still not right:

odd chars

ScottDowne commented 7 years ago

I noticed while the page is loading, it's fine. Then it hits setPageTitleL10N https://github.com/mozilla/testpilot/blob/master/frontend/src/app/containers/ExperimentPage.js#L214 and it updates the title, creating the issue. I think.

So maybe this is being caused by whatever is doing l10n?

ScottDowne commented 7 years ago

I think this and #1828 are related.

If you go here: https://github.com/l20n/l20n.js/blob/master/docs/html.md

At the bottom it says "If you care about IE11 you'll need the HTMLTemplateElement polyfill. L20n.js uses HTMLTemplateElements (