mozilla / tls-canary

DEPRECATED - TLS regression scanner for Firefox

https://tlscanary.mozilla.org/

Mozilla Public License 2.0

18 stars 15 forks source link

Cannot install OneCRL tools #106

Closed mwobensmith closed 7 years ago

mwobensmith commented 7 years ago

2017-07-13 17:56:32 INFO MainThread tlscanary.modes.basemode Updating OneCRL revocation data github.com/mozmark/OneCRL-Tools/oneCRL2RevocationsTxt ../../.tlscanary/go/src/github.com/mozmark/OneCRL-Tools/oneCRL2RevocationsTxt/main.go:43: undefined: oneCRL.DefineFlags ../../.tlscanary/go/src/github.com/mozmark/OneCRL-Tools/oneCRL2RevocationsTxt/main.go:48: undefined: oneCRL.GetConfig 2017-07-13 17:56:36 CRITICAL MainThread tlscanary.one_crl_downloader Cannot get Go package github.com/mozmark/OneCRL-Tools/oneCRL2RevocationsTxt

cr commented 7 years ago

Looks like this may require upstream fixing. When I run the installation manually, I get

$ GOPATH="/tmp/go" go get github.com/mozmark/OneCRL-Tools/oneCRL2RevocationsTxt
# github.com/mozmark/OneCRL-Tools/oneCRL2RevocationsTxt
/tmp/go/src/github.com/mozmark/OneCRL-Tools/oneCRL2RevocationsTxt/main.go:43: undefined: oneCRL.DefineFlags
/tmp/go/src/github.com/mozmark/OneCRL-Tools/oneCRL2RevocationsTxt/main.go:48: undefined: oneCRL.GetConfig

@mozmark, do you know what's going on? Has there been a recent update to the Go toolchain, perhaps?

cr commented 7 years ago

This is caused by incomplete upstream commit https://github.com/mozmark/OneCRL-Tools/commit/48acb6ad9d9d3b1e9e8c053be422a2fcd00e38c1 that landed today, but we can't do anything about this without upstream release tags.

cr commented 7 years ago

107 works around this issue by implementing Canary-side pinning.