Switching default OneCRL pin to 'stable' tag

mozilla / tls-canary

DEPRECATED - TLS regression scanner for Firefox

https://tlscanary.mozilla.org/

Mozilla Public License 2.0

18 stars 15 forks source link

Switching default OneCRL pin to 'stable' tag #127

Closed cr closed 6 years ago

cr commented 7 years ago

This resolves #62.

cr commented 7 years ago

Mind that #123 is breaking our tests, too. We have to test locally with s/nsILocalFile/nsIFile in scan_worker.js or land in the blind.

cr commented 7 years ago

Rebased on top of #125. Tests should be passing now.

cr commented 7 years ago

Now that's brilliant. The OneCRL "stable" version bails out with an error:

2017-08-09 17:03:09 INFO MainThread tlscanary.modes.basemode Updating OneCRL revocation data
# github.com/mozmark/OneCRL-Tools/oneCRL2RevocationsTxt
../../.tlscanary/go/src/github.com/mozmark/OneCRL-Tools/oneCRL2RevocationsTxt/main.go:51: multiple-value config.GetRecordURL() in single-value context

cr commented 7 years ago

I have filed mozmark/OneCRL-Tools/issues/40. There is no immediate pressure, but actually syncing up to OneCRL-Tools' stable tag was part of the milestone v3.1.2 release. Since that can't wait much longer, I am inclined to move this over to v3.1.3.

cr commented 7 years ago

Upstream tag has been fixed. This is now RTL. Thumbs up, @mwobensmith?

cr commented 7 years ago

How embarrassing. I missed to land this one. Should be good to land, but I'd wait for OneCRL-Tools's stable tag to move to https://github.com/mozilla/OneCRL-Tools/commit/3bf3462 or a later commit.

cr commented 6 years ago

Rebased the patch and finally advanced OneCRL-Tools' stable tag to a commit that works in TLS Canary. Travis should finally go green on this in a couple of minutes.