search

mozilla / tls-canary

DEPRECATED - TLS regression scanner for Firefox
https://tlscanary.mozilla.org/
Mozilla Public License 2.0
18 stars 15 forks source link

worker instances drop results without processing #151

Closed franziskuskiefer closed 2 years ago

franziskuskiefer commented 6 years ago

Running our harvester it often happens that at the start of a scan run the first few worker instances drop their results without processing many of the hosts assigned to them. For example:

WARNING Thread-1 tlscanary.worker_pool Worker task dropped results, yielded 8 instead of 50

These results are then missing at the end. @jallmann do you have a link to a run with this error?

mwobensmith commented 6 years ago

This is with the latest version of the canary, yes? What os/config is this running on?

I have been kicking off full runs on an AWS Ubuntu instance and have not seen this issue recently, so I'm curious to reproduce.

franziskuskiefer commented 6 years ago

The docker image we use for this is this one https://github.com/mozilla/canary-harvester/tree/master/docker. So it's the latest canary installed via pip on ubuntu:latest.

mwobensmith commented 6 years ago

Ah, thank you. I can reproduce now. I think this is something we fixed since last release. I'm assuming that these problems will go away if we update the latest TLS Canary release available via pip.

CR is on PTO at the moment, and I don't feel comfortable pushing a release w/o her approval. I think once she's back in a few days, it should be pretty easy.

franziskuskiefer commented 6 years ago

👍 Sounds good. Let me know when you released the new version and we'll update the docker image.

cr commented 6 years ago

TLS Canary v3.2.0 is out. Do these errors persist after pip install -U tlscanary?