mozilla / tls-canary

DEPRECATED - TLS regression scanner for Firefox
https://tlscanary.mozilla.org/
Mozilla Public License 2.0
18 stars 15 forks source link

Logic for testing with custom OneCRL entries is incorrect #87

Closed mwobensmith closed 7 years ago

mwobensmith commented 7 years ago

Just realized that this does not work as expected.

The desired behavior, when passing in -o custom, is to create a test profile with whatever OneCRL entries (revocations.txt) is inside the default profile directory. Also, whenever we create a base profile, we should intend to test with production data, which mimics the normal environment a user should have.

However, what is happening is that the base profile is being created using the same custom data as well. This means that we aren't doing an A/B test, but rather, an A/A test, which effectively isn't testing OneCRL.

mwobensmith commented 7 years ago

Fixed by PR #88.