In 1.2.37, I removed support for Subject SPKI (#144) and turned the value into standard SPKI. Turns out this was a mistake, and Subject SPKI is very much needed by CCADB. This patch re-adds it into a new column.
Checklist
[x] Run make, gofmt and golint your code, and run a test scan on your local machine before submitting for review.
[x] Workers needs an AnalysisPrinter, registered via worker.RegisterPrinter() (which is separate from worker.RegisterWorker()), and imported in tlsobs (example).
[x] When adding new columns to the database, also add a DB migration script under database/migrations named the next release (eg. if current release is 1.3.2, migration file will be 1.3.3.sql).
[x] When new columns require data to be recomputed, add a script under /tools (example) that updates the database and will be run by administrators.
In 1.2.37, I removed support for Subject SPKI (#144) and turned the value into standard SPKI. Turns out this was a mistake, and Subject SPKI is very much needed by CCADB. This patch re-adds it into a new column.
Checklist
make
,gofmt
andgolint
your code, and run a test scan on your local machine before submitting for review.worker.RegisterPrinter()
(which is separate fromworker.RegisterWorker()
), and imported in tlsobs (example).database/migrations
named the next release (eg. if current release is 1.3.2, migration file will be1.3.3.sql
)./tools
(example) that updates the database and will be run by administrators.